rambleraptor commented on code in PR #3649:
URL: https://github.com/apache/iceberg-python/pull/3649#discussion_r3739462863
##########
mkdocs/docs/api.md:
##########
@@ -1483,6 +1483,72 @@ Remove an existing branch:
table.manage_snapshots().remove_branch("dev").commit()
```
+#### Fast-forwarding a branch
+
+Fast-forward `from_branch` to point at the snapshot referenced by
+`to_ref`. `to_ref` may be a branch or tag; `from_branch` must be a
+branch. If `from_branch` does not yet exist it is created pointing at
Review Comment:
Worth adding that an auto-created from_branch gets default retention
properties.
##########
tests/table/test_manage_snapshots.py:
##########
@@ -177,3 +183,234 @@ def
test_set_current_snapshot_chained_with_create_tag(table_v2: Table) -> None:
# The main branch should point to the same snapshot as the tag
main_update = next(u for u in set_ref_updates if u.ref_name == "main")
assert main_update.snapshot_id == snapshot_one
+
+
+def test_fast_forward_branch_advances_to_descendant(table_v2: Table) -> None:
Review Comment:
Some test coverage gaps:
- A successful fast-forward where to_ref is a tag
- A no-op
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
