thswlsqls commented on PR #16871: URL: https://github.com/apache/iceberg/pull/16871#issuecomment-5229543083
@pvary Thanks for looking again — you're right, and the description is wrong: a null vector lands in `getPlainVectorAccessor`, and the line I cited is the `default` branch of `getDictionaryVectorAccessor`, which it never reaches. On fixing it properly — the Spark path already handles this in `ColumnVectorBuilder`, which checks `isDummy()`/`ConstantVectorHolder` and builds a `ConstantColumnVector` instead of going through the accessor factory; the Arrow `ColumnVector` has no such branch, so the null vector flows straight in. I'll rework this to handle `ConstantVectorHolder` the same way so the added column actually reads, and fix the description. Does that sound right to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
