xndai commented on code in PR #17557:
URL: https://github.com/apache/iceberg/pull/17557#discussion_r3752895574
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetrics.java:
##########
@@ -579,7 +587,12 @@ private ParquetVariantUtil.VariantMetrics counts() {
}
valueCount += column.getValueCount();
- nullCount += hasOnlyNullVariants ? column.getValueCount() :
stats.getNumNulls();
+ if (hasOnlyNullVariants) {
Review Comment:
yeah, this follows the similar logic for the other places where we don't
simply add stats.getNumNulls(). It's a bit challenging to construct a shredding
variant column with and without num nulls stats. Let me look into that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
