Copilot commented on code in PR #3778:
URL: https://github.com/apache/iceberg-python/pull/3778#discussion_r3754706761
##########
mkdocs/docs/configuration.md:
##########
@@ -653,6 +668,23 @@ catalog:
Use the `entra` auth type for Entra ID (Azure AD) authentication via
[DefaultAzureCredential](https://learn.microsoft.com/en-us/azure/developer/python/sdk/authentication/credential-chains?tabs=dac#defaultazurecredential-overview),
which supports environment variables, managed identity, Azure CLI, and more.
Install with `pip install pyiceberg[entra-auth]`.
<!-- prettier-ignore-end -->
+##### SeaweedFS
+
+[SeaweedFS](https://github.com/seaweedfs/seaweedfs) table buckets serve an
Iceberg REST catalog for table metadata and store the table data as Parquet
files behind the same S3 gateway:
+
+```yaml
+catalog:
+ seaweedfs_catalog:
+ type: rest
+ uri: http://<seaweedfs-host>:8181
+ warehouse: s3://<table-bucket-name>
+ credential: <access-key>:<secret-key>
+ s3.endpoint: http://<seaweedfs-host>:8333
+ s3.access-key-id: <access-key>
+ s3.secret-access-key: <secret-key>
Review Comment:
The example sets `credential` for the REST catalog but omits
`oauth2-server-uri`. In PyIceberg this triggers a deprecation warning (and the
implicit fallback will be removed), so the docs should show an explicit
`oauth2-server-uri` when using `credential` to fetch OAuth tokens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
