wombatu-kun commented on PR #16645: URL: https://github.com/apache/iceberg/pull/16645#issuecomment-5251351348
Both taken in 48ffe0b44. `testRewriteManifestsOnEmptyTable` is in as you wrote it, plus an assertion that the commit actually produces a `REPLACE` snapshot. The reach is narrower than it first looks: `RewriteManifestsSparkAction` already returns early on a null current snapshot, so only direct core-API callers reach the NPE. `validateDeletedManifests` now takes the `Snapshot`. The existing message is byte-identical, so the assertions on it in `testManifestReplacementConcurrentConflictingDelete` and `testDeleteManifestReplacementConflictingDeleteFileRemoval` still hold, and `testDeleteMissingManifestOnEmptyTable` pins the new one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
