uros-b opened a new pull request, #17608: URL: https://github.com/apache/iceberg/pull/17608
The `Metrics` constructors have no Javadoc, so it isn't documented what each map holds or that they may be null. This documents the canonical constructor that the other three delegate to. The maps and counts are all optional — `Metrics()` leaves everything null and the shorter constructors pass null for the arguments they omit — so each `@param` says so explicitly. Javadoc-only; no signature change. Note: draft #17451 adds an `avgValueSizes` parameter to this same constructor. Whichever lands first, the other rebases with a one-line adjustment (an added `@param` there, or a trivial context shift here). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
