QlikFrederic opened a new pull request, #3781:
URL: https://github.com/apache/iceberg-python/pull/3781
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
Closes #3779
# Rationale for this change
overwrite().delete_data_file(...) could fail for non-identity partition
transforms (for example bucket) because manifest-pruning predicate
reconstruction assumes identity semantics.
Change
In snapshot.py, update _build_delete_files_partition_predicate to:
- keep existing optimized partition-pruning behavior when all involved
partition fields are identity transforms
- fall back to non-pruning behavior when any involved spec uses a
non-identity transform by applying AlwaysTrue, so deletion still proceeds via
exact DataFile identity checks
This preserves the optimization for identity-only specs while restoring
working behavior for non-identity specs.
## Are these changes tested?
Added test_delete_data_file_manifest_pruning_bug.py, which verifies that
delete_data_file succeeds on bucket-partitioned tables and that the targeted
file is removed.
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
