pvary commented on code in PR #17430:
URL: https://github.com/apache/iceberg/pull/17430#discussion_r3759312642
##########
api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java:
##########
@@ -57,8 +57,8 @@
import org.apache.iceberg.util.UnicodeUtil;
import org.junit.jupiter.api.Test;
-public class TestInclusiveMetricsEvaluator {
- private static final Schema SCHEMA =
+public class TestInclusiveMetricsEvaluator<F> {
Review Comment:
Are we mixing 2 classes here?
- Base class where the abstract `protected F file()` is defined
- Implementation class where the `protected static final DataFile FILE` is
defined
##########
api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java:
##########
@@ -57,8 +57,8 @@
import org.apache.iceberg.util.UnicodeUtil;
import org.junit.jupiter.api.Test;
-public class TestInclusiveMetricsEvaluator {
- private static final Schema SCHEMA =
+public class TestInclusiveMetricsEvaluator<F> {
Review Comment:
Are we mixing 2 classes here?
- Base class where the abstract `protected F file()` is defined
- Implementation class where the `protected static final DataFile FILE` is
defined and the `protected F file()` is implemented using that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
