alexandre-normand commented on code in PR #1654:
URL: https://github.com/apache/iceberg-go/pull/1654#discussion_r3759918890
##########
udf/metadata_test.go:
##########
@@ -549,12 +550,12 @@ func TestMetadataValidation(t *testing.T) {
{
"malformed parameter",
func(t *testing.T, m map[string]any) { definition(t, m,
0)["parameters"] = []any{42} },
- nil, "cannot unmarshal number",
+ nil, "invalid character",
Review Comment:
I've reverted all of those changes. I agree about the assertion behavior but
I wanted to keep things focused on the improvement so I decided to leave out
revisiting this as part of the `catalog/rest` scoped down version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
