dgvj-work commented on issue #1716: URL: https://github.com/apache/iceberg-go/issues/1716#issuecomment-5257518499
Proposed approach for the PR: 1. **Names** — treat Java's `iceberg.hive.lock-check-min-wait-ms` / `iceberg.hive.lock-check-max-wait-ms` as the primary keys (integer milliseconds, matching Java). Keep the existing Go keys (`lock-check-min-wait-time` / `lock-check-max-wait-time`, Go duration strings) as aliases so current configs keep working. Java key wins if both are set. 2. **Defaults** — match Java: 50ms min / 5s max (today Go uses 100ms / 60s). 3. **Retries** — leave `lock-check-retries` as a Go-specific bound for now. Java uses `iceberg.hive.lock-timeout-ms` instead; wiring timeout through the acquire loop can be a follow-up. 4. **Validation** — reject non-positive waits/retries and `min-wait >= max-wait` at parse time (invalid values are ignored and defaults kept), instead of relying only on `applyJitter`/`calculateBackoff` defensiveness. Happy to adjust if maintainers prefer keeping Go defaults and only adding aliases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
