rdblue commented on code in PR #17413:
URL: https://github.com/apache/iceberg/pull/17413#discussion_r3762284847
##########
api/src/main/java/org/apache/iceberg/expressions/InclusiveEvalVisitor.java:
##########
@@ -64,6 +66,11 @@ protected <T> T extractUpperBound(BoundExtract<T> bound) {
return null;
}
+ /** Return a variant value as the given type, or null if it cannot be
represented as that type. */
+ protected static <T> T castTo(VariantValue value, Type type) {
Review Comment:
I don't see a reason to factor this out. It isn't used by
`InclusiveMetricsEvaluator` and it isn't overridden by
`InclusiveStatsEvaluator`. This isn't behavior that changes across
implementations and the `castTo` method is available in core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
