blackmwk commented on code in PR #2987:
URL: https://github.com/apache/iceberg-rust/pull/2987#discussion_r3763320306
##########
crates/property-macro/README.md:
##########
@@ -144,7 +148,9 @@ struct TableLikeProperties {
/// A single-key parser can validate and normalize a property value.
#[property(
key = LOCATION,
- default = "warehouse",
+ // Iceberg computes the real absent case as `<table-location>/data`.
+ // This literal is only an illustrative default for the macro example.
+ default = "<table-location>/data",
Review Comment:
This is incorrect, to correctly illustrate this field, you should:
1. Make `location` optional
2. Remove the getter
3. Add a manual created `location(&self): &str` method to hold the logic of
falling back to "<table-location>/data"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
