Copilot commented on code in PR #1790:
URL: https://github.com/apache/iceberg-go/pull/1790#discussion_r3769442333
##########
table/scanner_test.go:
##########
@@ -431,6 +398,40 @@ func (s *ScannerSuite) TestReadTasks() {
s.Require().False(valid)
})
}
+
+ s.Run("task residual", func() {
+ ctx := compute.WithAllocator(s.ctx, mem)
+ scan := tbl.Scan(table.WithRowFilter(iceberg.AlwaysTrue{}),
+ table.WithSelectedFields("number"))
+ tasks, err := scan.PlanFiles(ctx)
Review Comment:
This new subtest doesn’t use a `memory.NewCheckedAllocatorScope(mem)` like
the other `TestReadTasks` subtests, which makes it harder to localize Arrow
allocator leaks to this case (leaks would only show up at the end of the parent
test via `mem.AssertSize`). Consider adding the same scoped allocator check
here for consistency and faster leak diagnosis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
