rambleraptor commented on code in PR #3780:
URL: https://github.com/apache/iceberg-python/pull/3780#discussion_r3769687663
##########
pyiceberg/table/__init__.py:
##########
@@ -362,18 +362,21 @@ def _set_ref_snapshot(
return updates, requirements
def _build_partition_predicate(
- self, partition_records: set[Record], spec: PartitionSpec, schema:
Schema
+ self, partition_records: set[Record], spec: PartitionSpec, schema:
Schema, is_projected: bool = False
Review Comment:
I personally like that a lot. I'm wondering if we actually need the wrapper
methods and couldn't just pass in the field sets?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
