stevenzwu commented on code in PR #16294:
URL: https://github.com/apache/iceberg/pull/16294#discussion_r3770312590
##########
format/spec.md:
##########
@@ -960,6 +960,8 @@ A snapshot consists of the following fields:
| | | _required_ | **`added-rows`** |
The upper bound of the number of rows with assigned row IDs, see [Row
Lineage](#row-lineage) |
| | | _optional_ | **`key-id`** | ID
of the encryption key that encrypts the manifest list key metadata |
+In format version 4 and above, a snapshot's `timestamp-ms` must be strictly
greater than the `timestamp-ms` of its parent snapshot on the same branch. The
requirement applies only to snapshots committed while the table is at format
version 4 or higher; root snapshots, and snapshots that existed before a table
was upgraded to v4, are not constrained.
Review Comment:
> but as far as I can tell nothing durably records where that boundary is
with v4 snapshots and old grandfathered v3 snapshots.
We should add a `format-version` field to the snapshot metadata. This is
what I did in PR #17523 for the `Snapshot` interface change to support v4 root
manifest file pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
