laskoviymishka commented on PR #2986: URL: https://github.com/apache/iceberg-rust/pull/2986#issuecomment-5279592081
Thanks for the review! Pushed a follow-up commit addressing all four: - Added a note to the module docs that position delete files are a v2 construct — v3 replaces them with deletion vectors and forbids new position delete files, so callers must not route v3 writes here, and format-version gating stays at the transaction/commit layer rather than this base writer. - Made `position_delete_arrow_schema` crate-internal. Since only the tests consume it today, I gated it (and its backing static) under `#[cfg(test)]` to avoid a dead-code warning; I'll widen it to `pub(crate)` when a higher-level writer actually needs the Arrow form. `position_delete_schema` stays public. - Added a test that reads the written file's Parquet schema and asserts the two reserved column field ids (2147483546 / 2147483545) survive the write. - Added a test for the `field_id` parse-error branch (metadata present but not an integer). Also merged latest `main` in. Let me know if you'd prefer `position_delete_arrow_schema` kept as `pub(crate)` regardless — happy to switch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
