sqd commented on code in PR #17618:
URL: https://github.com/apache/iceberg/pull/17618#discussion_r3776755988
##########
api/src/main/java/org/apache/iceberg/Schema.java:
##########
@@ -81,6 +81,7 @@ public class Schema implements Serializable {
private transient Map<Integer, Accessor<StructLike>> idToAccessor = null;
private transient Map<Integer, String> idToName = null;
private transient Set<Integer> identifierFieldIdSet = null;
+ private transient Set<String> identifierFieldNameSet = null;
Review Comment:
I agree that this is not strictly required to address the PR issue. Although
I thought this is cleaner (fewer special case) and it would make
identifierFieldName follow the memoization pattern already used multiple times
in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
