plusplusjiajia commented on code in PR #2838:
URL: https://github.com/apache/iceberg-rust/pull/2838#discussion_r3776947129
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -367,9 +471,25 @@ struct RestContext {
endpoints: HashSet<Endpoint>,
}
+impl RestContext {
+ /// Testing only: the bearer token the catalog session would attach.
+ #[cfg(test)]
+ async fn token(&self) -> Option<String> {
+ self.client.token().await
+ }
+
+ /// Sends `request`, authenticated by the client's session.
+ async fn query_catalog(&self, request: HttpRequest) -> Result<Response> {
Review Comment:
@CTTY Agreed — query_catalog still hands back a reqwest::Response, so the
wrapper is only half there. Filed #2993
(https://github.com/apache/iceberg-rust/issues/2993) to track it; I'll pick it
up after this lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
