dramaticlly commented on PR #17626: URL: https://github.com/apache/iceberg/pull/17626#issuecomment-5284183777
> 4.0/4.1 look good since those were deprecated in 1.11 for 1.12 removal. But I'm a bit concerned about 3.5 because removing them now is a breaking change for anyone still calling them on 3.5. Could we deprecate them in 3.5 this release and remove them in a later one? Thanks @huaxingao, originally I was hoping to align the spark changes among 3.5/4.0/4.1 to have consistent code base but directly removal of public without 1 cycle of deprecation notice might introduce more problem than version consistency. Given that we might also drop the spark 3.5 after the 4.2 addition, I revert the change in 3.5 and only remove the deprecated method in 4.0 and 4.1. I plan to have a separate PR for Position-delete-with-row-data family and SparkTableUtil -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
