kinolaev commented on code in PR #15713:
URL: https://github.com/apache/iceberg/pull/15713#discussion_r3782876314


##########
core/src/test/java/org/apache/iceberg/TestTables.java:
##########
@@ -410,4 +411,106 @@ public void deleteFiles(Iterable<String> pathsToDelete) 
throws BulkDeletionFailu
       throw new RuntimeException("Expected to mock this function");
     }
   }
+
+  /** A {@link FileIO} that enforces a limit on concurrent open input streams. 
*/
+  public static class TrackingFileIO implements FileIO {

Review Comment:
   Thanks, @pvary, I tried extending `TrackingFileIO` to reuse it in 
`TestSparkExecutorCache` and `TestStreamingCheckpointHadoopIO`. However, while 
they look similar, they are initialized differently and track different things. 
There isn't much to reuse, so it's not worth it. I moved `TrackingFileIO` next 
to the test that uses it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to