zeroshade commented on issue #696: URL: https://github.com/apache/iceberg-go/issues/696#issuecomment-5295313448
the io package implementation isn't a separate go.mod yet, so gocloud.dev would still show up in the `go mod graph`. In addition, it's still imported * by `cmd/iceberg/` CLI mainprog as the default implementation for object stores * by several test files across multiple packages * by the hadoop catalog If you don't import the hadoop catalog and aren't building the tests, then the go compiler would drop the dependency during build, but it'll still show up in the go.mod and `go mod graph` because it's not a separate go.mod yet. If you want to entirely remove the dependency on gocloud.dev from the `go.mod` then we'd need to make the integration tests an entirely separate go.mod and remove all references to `io/gocloud/` from the `*_test.go` files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
