rdblue commented on a change in pull request #1891:
URL: https://github.com/apache/iceberg/pull/1891#discussion_r553673788
##########
File path: site/docs/configuration.md
##########
@@ -35,6 +35,20 @@ The properties can be manually constructed or passed in from
a compute engine li
Spark uses its session properties as catalog properties, see more details in
the [Spark configuration](#spark-configuration) section.
Flink passes in catalog properties through `CREATE CATALOG` statement, see
more details in the [Flink](../flink/#creating-catalogs-and-using-catalogs)
section.
+### Lock catalog properties
+
+Here are the catalog properties related to locking. They are used by some
catalog implementations to control the locking behavior during commits.
+
+| Property | Default | Description
|
+| --------------------------------- | ------------------ |
------------------------------------------------------ |
+| lock.impl | null | a custom
implementation of the lock manager, the actual interface depends on the catalog
used |
Review comment:
The other implementation class properties are `something-impl`.
Shouldn't this be `lock-impl` instead to match those? Then the other properties
are in the `lock` namespace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
