joyhaldar commented on code in PR #17610:
URL: https://github.com/apache/iceberg/pull/17610#discussion_r3788523935
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -114,6 +114,19 @@ protected boolean supportsBatchReads() {
return false;
}
+ protected boolean readOnly() {
+ return false;
+ }
+
+ protected Set<FileFormat> supportedFormats() {
Review Comment:
Thank you @pvary.
1. Made `DataGenerator`, `DataGenerators` and `DataGenerators.ALL` public in
the test package.
2. `TestSparkVectorizedFormatModel` redefines both `FILE_FORMATS` and
`FORMAT_AND_GENERATOR`.
3. Dropped `supportedFormats()` and all the per test
`assumeSupportedFormat()` calls from the base class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
