wgtmac commented on PR #726: URL: https://github.com/apache/iceberg-cpp/pull/726#issuecomment-5302376847
I did another cleanup pass to align this PR with repository conventions: kept SpdLogger behind a non-installed internal header, made it own spdlog::logger by value, simplified the CMake/Meson feature gating, and switched the tests to an injected ostream sink for Windows portability. This keeps spdlog out of the public API while preserving clean no-spdlog builds. Thanks for working on this, @kamcheungting-db! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
