daviddallakyan2005 commented on PR #3801: URL: https://github.com/apache/iceberg-python/pull/3801#issuecomment-5303702453
That makes sense, thanks. Looking at it again, I agree that an empty string is not useful for typed properties. Unlike `0` in #3660, it is not a valid value, so unsetting the property is clearer. I also noticed that `get_first_property_value` is mainly used for AWS credential and region fallbacks. Returning an empty string could prevent a valid fallback from being used. I can close this PR, or change the checks to be more explicit without changing the current behavior. Which would you prefer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
