plusplusjiajia commented on PR #889: URL: https://github.com/apache/iceberg-cpp/pull/889#issuecomment-5312594504
> I've made some refactoring to the FileIO resolution. Let me know what you think. @plusplusjiajia @wgtmac Thanks for looping me in — registry-driven resolution is right, and `shared_ptr` delegates close a real use-after-free window. credential prefixes — agree.** `s3`/`s3a`/`s3n` matches Java's `S3FileIO`. routing — I'd keep `oss`.** This is stricter than Java: `S3URI` applies no scheme whitelist, and its javadoc says it "supports any valid URI schemes ... allows users to use S3FileIO with other S3-compatible object storage services". PyIceberg routes `oss` the same way ([map](https://github.com/apache/iceberg-python/blob/03ad0d6c/pyiceberg/io/__init__.py#L322), [init](https://github.com/apache/iceberg-python/blob/03ad0d6c/pyiceberg/io/pyarrow.py#L450)). `ArrowS3FileIO` is equally capable — `ResolvePath` already handles foreign schemes — so `kS3Schemes` is a new gate, and an unmatched scheme is a hard `NotSupported`, which makes such stores unusable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
