dramaticlly opened a new pull request, #17700: URL: https://github.com/apache/iceberg/pull/17700
Removes the remaining core API marked for removal in 1.12.0 that has no callers left. Each item is an independent deletion; grouping them keeps the review to one pass over one module rather than nine tiny PRs. | Removed | Replacement | |---|---| | `SystemProperties` (class) | `SystemConfigs` | | `ThreadPools.newWorkerPool(String)`, `newWorkerPool(String, int)` | `newExitingWorkerPool` for long-lived pools, `newFixedThreadPool` for short-lived | | `ContentCache.invalidateAll()` | none — was best-effort and racy by design | | `TableProperties.MANIFEST_LISTS_ENABLED`, `MANIFEST_LISTS_ENABLED_DEFAULT` | none — writing manifest lists is always enabled | | `AvroSchemaUtil.pruneColumns(Schema, Set, NameMapping)` | `applyNameMapping` + `pruneColumns(Schema, Set)` | | `SnapshotUtil.newFiles`, `newFilesBetween` | `SnapshotChanges` with `ancestorsBetween` | | `TableScanUtil.hasDeletes(CombinedScanTask)`, `hasEqDeletes(CombinedScanTask)` | the `FileScanTask` overloads | | `StandardEncryptionManager(String, int, KeyManagementClient)`, `wrapKey`, `unwrapKey` | the constructor taking encryption keys | | `ManifestFiles.read(ManifestFile, FileIO)`, `readPaths(ManifestFile, FileIO)`, `open(ManifestFile, FileIO)` | the overloads taking a specs map | | `BaseScan.io()` | `table().io()` | The only change that is not a pure deletion: `BaseScan.io()` was a `protected` helper, so its two subclass users are migrated to call `table().io()` directly — `DataScan` (1 site) and `BaseDistributedDataScan` (3 sites). No engine module subclasses used it. ## AI Disclosure Model: Claude Opus 5 (1M context) Platform/Tool: Claude Code Human Oversight: reviewed Prompt Summary: split #16449 into smaller self-contained PRs; verify each group compiles and tests green standalone -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
