mxm commented on code in PR #17630:
URL: https://github.com/apache/iceberg/pull/17630#discussion_r3801087351
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/EqualityConvertPKIndex.java:
##########
@@ -150,15 +149,15 @@ public void open(OpenContext context) throws Exception {
public void processElement(IndexCommand cmd, ReadOnlyContext ctx,
Collector<DVPosition> out)
throws Exception {
try {
- Long storedGeneration = indexGeneration.value();
- if (!Objects.equals(storedGeneration, cmd.indexGeneration())) {
+ Long storedSequence = mainSequenceVersion.value();
+ if (!Objects.equals(storedSequence, cmd.mainSequenceNumber())) {
Review Comment:
Thanks! I agree on the tightness, but I prefer consistency over tightness
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
