singhpk234 commented on code in PR #17697:
URL: https://github.com/apache/iceberg/pull/17697#discussion_r3801907308
##########
.palantir/revapi.yml:
##########
@@ -609,18 +621,35 @@ acceptedBreaks:
justification: "These interfaces were package-private in 1.11.0 and
could not\
\ be implemented outside the project. Promoting them to public reads
as an\
\ existing type gaining methods, not as a new type appearing."
+ - code: "java.method.removed"
+ old: "method java.lang.String
org.apache.iceberg.rest.RESTUtil::encodeNamespace(org.apache.iceberg.catalog.Namespace)"
+ justification: "Removing deprecated REST namespace encoding API
scheduled for\
Review Comment:
```suggestion
justification: "Removed deprecated REST namespace encoding API
scheduled for\
```
##########
core/src/main/java/org/apache/iceberg/rest/RESTUtil.java:
##########
@@ -188,8 +173,8 @@ public static String namespaceToQueryParam(Namespace
namespace) {
/**
* This converts the given namespace to a string and separates each part in
a multipart namespace
- * using the provided unicode separator. Note that this method is different
from {@link
- * RESTUtil#encodeNamespace(Namespace)}, which uses a UTF-8 escaped
separator.
+ * using the provided unicode separator. Note that this method uses the raw
unicode separator,
+ * unlike the percent-encoded form used by the REST catalog path encoding.
Review Comment:
Note: i wonder if Note is required ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
