badalprasadsingh commented on issue #1825:
URL: https://github.com/apache/iceberg-go/issues/1825#issuecomment-5330728555
I confirmed your path finding on my `macOS`.
Right now, `LoadLocationProvider("C:\...")` makes `NewDataLocation`,
`NewMetadataLocation` and `NewTableMetadataFileLocation` all silently return
the bare root, `err = nil`. Similar at the catalog layer:
`url.JoinPath("C:\wh", "ns.db", "tbl")` returns `c:\wh`, so every table in
every namespace collapses onto one path.
Before you file, please check #1262. It already tracks this ("data and
metadata dirs never nest") and names `url.Parse` drive letters as the suspected
cause; it's why windows-latest is commented out in CI. It's, right now,
unassigned with no comments, so post your root-cause detail there as a comment
rather than opening a duplicate. Also see PR #1644, adding portable path
normalization in `internal/fileuri` is likely reusable, so coordinate rather
than write a third normalizer.
But, for this issue: narrow the title / body to the
`CompareAndDelete`/`abortAll` leak and go ahead with that PR now. It reproduces
without Windows, any mid-stream write error strands the batches buffered in
`recordCh`.
cc: @laskoviymishka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
