dramaticlly commented on code in PR #17706:
URL: https://github.com/apache/iceberg/pull/17706#discussion_r3810589213
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java:
##########
@@ -230,28 +227,15 @@ public DataWriter<InternalRow> createWriter(int
partitionId, long taskId) {
if (formatVersion >= 3) {
return new DVWriter(table, deleteFileFactory, dsSchema, specId,
partition);
} else {
- Schema positionDeleteRowSchema = positionDeleteRowSchema();
- StructType deleteSparkType = deleteSparkType();
- StructType deleteSparkTypeWithoutRow = deleteSparkTypeWithoutRow();
-
- SparkFileWriterFactory writerFactoryWithRow =
- SparkFileWriterFactory.builderFor(table)
- .deleteFileFormat(format)
- .positionDeleteRowSchema(positionDeleteRowSchema)
- .positionDeleteSparkType(deleteSparkType)
- .writeProperties(writeProperties)
- .build();
- SparkFileWriterFactory writerFactoryWithoutRow =
+ SparkFileWriterFactory writerFactory =
Review Comment:
yeah I think it make sense, both position delete rewrite and table path
rewrite will need to deal to existing PDWR. Given that we are removing all the
basic writer in parquet I opted to throw exception and fail loudly instead. The
expectation would be handle the PDWR conversion outside instead of silently
drop the row in existing PD. Wondering if this align with your expectation ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
