tomtongue commented on code in PR #16859:
URL: https://github.com/apache/iceberg/pull/16859#discussion_r3817800257
##########
core/src/main/java/org/apache/iceberg/MetadataTableUtils.java:
##########
@@ -70,6 +70,8 @@ private static Table createMetadataTableInstance(
return new SnapshotsTable(baseTable, metadataTableName);
case METADATA_LOG_ENTRIES:
return new MetadataLogEntriesTable(baseTable, metadataTableName);
+ case TABLE_PROPERTIES_LOG:
+ return new TablePropertiesLogTable(baseTable, metadataTableName);
Review Comment:
@singhpk234 Thanks for checking each concern and sharing the related PRs.
@szehon-ho also, thanks for raising the masking concern.
From those PRs, adding `properties` as the optional column sounds reasonable
and should have limited impact.
Regarding masking or allowlisting all versions of table props, I also think
it's better handled at the platform or catalog layer as the table access
management.
Based on those feedback, I'll proceed with adding an optional `properties`
column to the existing `metadata_log_entries` table first. Also it will return
`null` when a referenced metadata file is missing. If there's any issues while
implementing it, I'll share with you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
