adutra commented on code in PR #17709:
URL: https://github.com/apache/iceberg/pull/17709#discussion_r3821738788
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalogProperties.java:
##########
@@ -100,12 +99,39 @@ public static ScanPlanningMode fromString(String mode) {
/**
* The base URI of the remote signer endpoint. Optional, defaults to {@link
* CatalogProperties#URI}.
+ *
+ * @deprecated Will be removed in 1.13; there is no replacement.
*/
- public static final String SIGNER_URI = "signer.uri";
+ @Deprecated public static final String SIGNER_URI = "signer.uri";
/**
* The endpoint path of the remote signer endpoint. If remote signing has
been requested, this
* must be set.
+ *
+ * @deprecated Will be removed in 1.13; there is no replacement.
*/
- public static final String SIGNER_ENDPOINT = "signer.endpoint";
+ @Deprecated public static final String SIGNER_ENDPOINT = "signer.endpoint";
+
+ /**
+ * The remote signing endpoint path, as computed by {@link
+ * ResourcePaths#remoteSign(org.apache.iceberg.catalog.TableIdentifier)}.
+ *
+ * <p>This property is automatically set by the REST catalog client when
creating table-scoped
+ * FileIO instances, and is intended for consumption by remote request
signers.
+ *
+ * <p>It is not intended for user-facing configuration, and may be removed
or changed in future
+ * releases without notice.
+ */
+ public static final String REMOTE_SIGNING_ENDPOINT =
"rest.remote-signing.endpoint";
+
+ /**
+ * The {@link RemoteSigningConfig}, JSON-encoded.
+ *
+ * <p>This property is automatically set by the REST catalog client when
creating table-scoped
+ * FileIO instances, and is intended for consumption by remote request
signers.
+ *
+ * <p>It is not intended for user-facing configuration, and may be removed
or changed in future
Review Comment:
It refers to this property: since it's internal to the REST catalog client
and its FIleIO instances, we should be allowed to remove it if it's not needed
anymore in the future. Let me rephrase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
