rdblue commented on pull request #2050: URL: https://github.com/apache/iceberg/pull/2050#issuecomment-756931684
@danielcweeks, the convention is to use `.` as a delimiter for grouping and `-` between multiple words of the same term. For example, in `s3fileio.multipart.part.size` the `part` is not a group or namespace for properties, it is one word of "part size". Similarly, `bytes` is part of the thing being configured and we would not expect to see other properties nested within `size`. Other projects use a convention where all words are separated by `.` regardless, but I think it is easier to understand the context hierarchy if things described by more than one word are kept together. Also, `lock.impl` vs `lock-impl` is a fuzzy case since `lock` _is_ a group, but I think this should match the others, like `io-impl`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
