dkranchii commented on code in PR #17745:
URL: https://github.com/apache/iceberg/pull/17745#discussion_r3831883099
##########
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java:
##########
@@ -183,9 +184,15 @@ private Set<String> findFilesToDelete(
"Failed to determine live files in manifest {}. Retrying",
item.path(), exc))
.run(
manifest -> {
- try (CloseableIterable<String> paths =
- ManifestFiles.readPaths(manifest, fileIO, specsById)) {
Review Comment:
Great suggestion - done. ReachableFileCleanup is the only caller of
ManifestFiles.readPaths in the repo, so moving the fix upstream is a much
smaller and more central change. readPaths now dispatches through
ManifestFiles.open (which already switches between DATA and DELETE readers)
instead of read. ReachableFileCleanup.java is back to its pre-PR state - the
entire change is now a one-line swap in ManifestFiles plus a javadoc update to
reflect that DELETE manifests are supported. Any future caller of readPaths
inherits correct behavior for both manifest types automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
