blackmwk commented on code in PR #3030:
URL: https://github.com/apache/iceberg-rust/pull/3030#discussion_r3835714465
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -1018,6 +1019,8 @@ pub(super) mod _serde {
})?
.into();
let default_partition_type =
default_spec.partition_type(current_schema)?;
+ let properties = value.properties.unwrap_or_default();
+ let table_properties = TableProperties::try_from(&properties)?;
Review Comment:
Thanks for the review, I added a `try_from_loosely` method in
https://github.com/apache/iceberg-rust/pull/3044 so that we could parser
properties in a reader friendly way, e.g. when one property failed to be
parsed, we use its default value, rather than fail the whole parsing, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
