dkranchii opened a new pull request, #17772:
URL: https://github.com/apache/iceberg/pull/17772
## Summary
Extend `TestRemoveSnapshots` to run every test against format version 3 in
addition to V1 and V2, and make `testExpireWithDeleteFiles` version-agnostic so
it exercises both V2 position-delete parquet files and V3 deletion vectors.
## Motivation
Follow-up to reviewer feedback on #17745 asking for expanded V3 coverage in
`TestRemoveSnapshots`. V3 has been the default table format for new writes in
recent releases but the snapshot-expiration test class only exercised V1 and
V2. This closes that gap for the whole class, not just the delete-file test.
## Changes
- `@Parameters` matrix gains `{3, true}` and `{3, false}` entries, so every
`@TestTemplate` in the class runs against V3 for both the incremental and
reachable cleanup strategies.
- `testExpireWithDeleteFiles` now uses the existing `fileADeletes()` /
`fileBDeletes()` helpers from `TestBase` (which return position deletes for V2
and DVs for V3) instead of hardcoded `FILE_A_DELETES` / `FILE_B_DELETES`.
Version guard widened from `isEqualTo(2)` to `isIn(2, 3)`.
V1 has no delete files and V4+ folds delete entries into the root manifest,
so V2 and V3 remain the only versions that carry standalone delete manifests.
## Test plan
- [x] `./gradlew :iceberg-core:test --tests
"org.apache.iceberg.TestRemoveSnapshots"` passes for all six parameter
combinations (V1/V2/V3 × incremental/reachable).
---
**AI Disclosure**
- Platform/Tool: Cursor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
