aboueleyes commented on PR #15989:
URL: https://github.com/apache/iceberg/pull/15989#issuecomment-5385967870
Thanks @uros-b
Cross-linking from #17769, which we are closing in favor of this PR as part
of consolidation.
Three small things from that PR that this one does not seem to cover,
offered in case they are useful:
1. `TestHTTPRequest`: an added case asserting percent-escaped segments
survive request-URI construction unchanged
(`v1/main%7Cwarehouse/namespaces/sales%20report/...` round-trips the escapes
byte-for-byte through hc5's URIBuilder).
2. Endpoint coverage in `TestResourcePaths` beyond `table()`: metrics,
remoteSign, view,
planTableScan, plan (including a plan ID holding both a space and a
literal plus), fetchScanTasks, and the namespace-only routes (`namespace`,
`namespaceProperties`, `tables`, `register`, `views`, `registerView`) with a
spaced namespace.
3. Issue #17759 as a fixes-reference: it documents the live Nessie
reproduction (`sales%20report` -> 200 vs `sales+report` -> 404) that motivates
the client-side change.
Happy to provide any of these as a patch on top of your branch if easier
than hand-porting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
