aboueleyes commented on PR #17769:
URL: https://github.com/apache/iceberg/pull/17769#issuecomment-5385961121
Yes, happy to consolidate.
@adutra's #15989 predates this PR, already carries approvals and review, and
its RFC 3986 approach via `PercentCodec` is stricter than the
`URLEncoder`-based substitution here.
This PR has three small additions that #15989 does not appear to cover; I
will offer them over there:
1. A `TestHTTPRequest` case pinning that percent-escaped segments (`%20`,
`%7C`) pass through
request-URI construction unmodified.
2. Per-endpoint path coverage with spaces and literal pluses across metrics,
remote-signing,
view, plan, plan-ID and scan-task builders, plus the six namespace-only
routes.
3. Cross-linking issue #17759 so the Nessie reproduction stays attached to
the fix that lands.
Closing this in favor of #15989. Thanks @uros-b for flagging and @adutra for
the cleaner implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
