Prabal864 commented on PR #17752: URL: https://github.com/apache/iceberg/pull/17752#issuecomment-5386074805
Thanks for flagging this @uros-b - didn't see #17540 was already open for the same fix. Closing this in favor of that one since it was opened first. One thing this PR added that #17540 doesn't have: a regression test (`customCredentialsProviderWithoutRefreshEndpointDoesNotPassNullUri`) covering the case where a custom credentials provider re-derives its own `AwsClientProperties` from the properties map and NPEs on the null `VendedCredentialsProvider.URI` value. I'll leave that as a suggestion on #17540 in case it's useful there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
