Sakshamm-Goyal opened a new pull request, #896:
URL: https://github.com/apache/iceberg-cpp/pull/896

   ## Summary
   
   - install the missing public headers in Meson and the top-level catalog 
headers in CMake
   - include `snapshot_summary_builder_test.cc` in Meson's `table_test`
   - align the CRoaring, nlohmann/json, and GoogleTest fallback versions across 
CMake and Meson
   - add a dependency-free parity regression and run it in CI
   
   Closes #894.
   
   ## Validation
   
   - `python3 dev/test_build_definition_parity.py`
   - `pre-commit run --files .github/workflows/test.yml 
cmake_modules/IcebergThirdpartyToolchain.cmake 
src/iceberg/catalog/CMakeLists.txt src/iceberg/catalog/rest/auth/meson.build 
src/iceberg/meson.build src/iceberg/test/meson.build 
dev/test_build_definition_parity.py`
   - CMake configure with bundle/REST disabled, followed by `cmake --build 
build-cmake-parity --target table_test --parallel 2`
   - `ctest --test-dir build-cmake-parity -R '^table_test$' --output-on-failure`
   - Meson configure with REST/tests enabled, followed by `meson compile -C 
build-meson-parity table_test -j 2`
   - `meson test -C build-meson-parity table_test --print-errorlogs`
   - inspected both generated install manifests for the corrected public headers
   
   ## AI assistance disclosure
   
   AI-assisted tooling was used for initial regression-test scaffolding and 
mechanical build-definition edits. I reviewed the change end-to-end, verified 
the dependency choices and generated manifests, and ran the validations listed 
above. I am not aware of remaining uncertainty in the affected build paths.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to