xanderbailey commented on code in PR #3055:
URL: https://github.com/apache/iceberg-rust/pull/3055#discussion_r3839391634
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -1133,6 +1134,22 @@ impl SessionCatalog for RestSessionCatalog {
let table_ident = TableIdent::new(namespace.clone(),
creation.name.clone());
+ let mut properties = creation.properties;
+
+ if properties.contains_key(TableProperties::PROPERTY_FORMAT_VERSION) {
+ return Err(Error::new(
+ ErrorKind::DataInvalid,
+ format!(
+ "Table properties should not contain reserved properties,
but got: [{}]. Set `TableCreation::format_version` instead",
+ TableProperties::PROPERTY_FORMAT_VERSION
+ ),
+ ));
+ }
Review Comment:
This is a break technically but I think it's a legitimate break that we can
document in the upgrade docs for 0.11.0
We could also allow the property IF it matches the `format_version` provided?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
