ebyhr commented on code in PR #17784:
URL: https://github.com/apache/iceberg/pull/17784#discussion_r3840040111
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -119,10 +119,12 @@ public AzureProperties(Map<String, String> properties) {
}
if (properties.containsKey(ADLS_READ_BLOCK_SIZE)) {
- this.adlsReadBlockSize =
Integer.parseInt(properties.get(ADLS_READ_BLOCK_SIZE));
+ this.adlsReadBlockSize =
+ PropertyUtil.propertyAsNullableInt(properties, ADLS_READ_BLOCK_SIZE);
Review Comment:
We can eliminate the `if` condition above, right?
##########
azure/src/test/java/org/apache/iceberg/azure/TestAzureProperties.java:
##########
@@ -318,4 +319,15 @@ public void initialize(Map<String, String>
credentialProperties) {
properties = credentialProperties;
}
}
+
+ @Test
+ public void testNullBlockSizesAreIgnored() {
Review Comment:
https://iceberg.apache.org/contribute/#conventions-and-recommendations
> Omit the test prefix for newly added test methods.
```suggestion
public void nullValuesAreIgnored() {
```
There is no need to include "BlockSizes" in my opinion. We may add new
entries in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
