umatt1 commented on PR #17786: URL: https://github.com/apache/iceberg/pull/17786#issuecomment-5389648658
Thanks for the review @ebyhr! Addressed all four points in 8bf6b03c7: - `PropertyUtil.propertyAsNullableInt` for both timeout properties - Removed the presence guard — transport options are now always set (verified the `httpTimeoutsNotSetByDefault` test still passes, since `newBuilder().build()` matches the library defaults) - `hasValue()` for the Optional assertions - Trimmed the test comments down to the two things a future reader needs (why the unresponsive server, why `maxAttempts(1)`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
