plusplusjiajia commented on PR #892:
URL: https://github.com/apache/iceberg-cpp/pull/892#issuecomment-5392227283
> Thanks for adding this feature! I think it is too large to review which
may incur a long delay. Perhaps let's split it into smaller ones so we can
review it one by one?
@wgtmac Thanks for the suggestion — splitting it definitely makes this
easier to review. Smallest first:
1. #897 — the S3 test suites stop probing the EC2 metadata service (54s →
0.3s).
2. #898 — ArrowS3FileIO gets the treatment #889 gave ResolvingFileIO:
shared_ptr delegates, a shared_mutex, delegate construction off the lock. No
behavior change.
3. Next: the LoadCredentials plumbing — response parsing, a refresher
callback built from the endpoint, forwarded through ResolvingFileIO but not yet
invoked. Opens once #898 merges.
4. This PR then shrinks to just the policy: read
`s3.session-token-expires-at-ms`, refresh five minutes early, back off on
failure, discard superseded result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
