xanderbailey commented on code in PR #2997: URL: https://github.com/apache/iceberg-rust/pull/2997#discussion_r3841906812
########## crates/iceberg/public-api.txt: ########## @@ -1344,7 +1358,6 @@ pub struct iceberg::scan::TableScan impl iceberg::scan::TableScan pub fn iceberg::scan::TableScan::column_names(&self) -> core::option::Option<&[alloc::string::String]> pub async fn iceberg::scan::TableScan::plan_files(&self) -> iceberg::Result<iceberg::scan::FileScanTaskStream> -pub fn iceberg::scan::TableScan::snapshot(&self) -> core::option::Option<&iceberg::spec::SnapshotRef> Review Comment: This was only used in tests and is now ambiguous in the case of incremental scans so I think this is fine to remove. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
