kinolaev commented on PR #17196:
URL: https://github.com/apache/iceberg/pull/17196#issuecomment-5394056920
@RussellSpitzer, I'd be happy to keep working on this and hopefully get the
PR wrapped up this week. Please take another look when you get a chance.
I've rebased my branch to resolve conflicts. There are no other changes
since my last comment.
Status:
1. AvroSchemaUtil:
1. Iceberg->Avro: `local-timestamp-*` by default, no flag
1. Avro->Iceberg: `adjustToUtcDefault` flag, `false` by default
1. `isTimestamptz` is inlined at its call sites
1. Readers and writers:
1. support `local-timestamp-*`
1. `adjustToUtcDefault` can be configured via the
`SupportsLocalTimestamp` interface
1. `Avro` passes the `write.avro.local-timestamp.enabled` (default is false)
and `read.avro.adjust-to-utc.default` (default is false) properties to the
readers and writers
1. Manifests:
1. `adjustToUtcDefault` is pinned to `false` in Avro->Iceberg convert
calls
1. package-private `AvroLegacyTimestamps` is introduced to convert
`local-timestamp-*` back to `timestamp-*` across 5 classes for backward
compatibility (see my previous comment)
1. `write.avro.local-timestamp.enabled` is pinned to `false` for all
manifest writer versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
