ldudas-marx commented on code in PR #17723:
URL: https://github.com/apache/iceberg/pull/17723#discussion_r3843280466
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/NullabilityHolder.java:
##########
@@ -23,10 +23,11 @@
/**
* Instances of this class simply track whether a value at an index is null.
For simplicity and
* performance, it is expected that various setter methods {@link
#setNull(int)}, {@link
- * #setNulls(int, int)}, {@link #setNotNull(int)} and {@link #setNotNulls(int,
int)} are invoked
- * with monotonically increasing values for the index parameter.
+ * #setNulls(int, int, int)}, {@link #setNotNull(int, int)} and {@link
#setNotNulls(int, int, int)}
+ * are invoked with monotonically increasing values for the index parameter.
*/
public class NullabilityHolder {
+ private final int[] definitionLevels;
Review Comment:
I plan to refactor this class and (use a bitmap to save more space and
isNullAt(index) could return a bool), but the change set is large enough
without that so I did the quick and dirty addition of this new array and merge
the two together later.
For now I would extract the interface and create a separate
DefinitionLevelHolder class which only stores the definitionsLevels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
