gaborkaszab commented on code in PR #17598:
URL: https://github.com/apache/iceberg/pull/17598#discussion_r3843025003
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -546,6 +546,10 @@ private static Map<String, String> defaultQueryParams() {
SnapshotMode.ALL.toString().toLowerCase(Locale.US));
}
+ private static String entityTag(String metadataLocation, Map<String, String>
queryParams) {
+ return "\"" + ETagProvider.of(metadataLocation, queryParams) + "\"";
Review Comment:
Why not change ETagProvider to return quoted string? We wouldn't rely on the
user of the provider to quote the tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
