singhpk234 commented on code in PR #17789:
URL: https://github.com/apache/iceberg/pull/17789#discussion_r3845144429
##########
aws/src/main/java/org/apache/iceberg/aws/lakeformation/LakeFormationAwsClientFactory.java:
##########
@@ -84,7 +99,8 @@ public S3Client s3() {
.applyMutation(s3FileIOProperties()::applyServiceConfigurations)
.applyMutation(s3FileIOProperties()::applyRetryConfigurations)
.credentialsProvider(
- new LakeFormationCredentialsProvider(lakeFormation(),
buildTableArn()))
+ new LakeFormationCredentialsProvider(
+ lakeFormation(), buildTableArn(), cacheEnabled,
cacheRefreshLeadTimeMs))
Review Comment:
[orthogonal] wow, we take props rather than dynamically inferring like
VendedCredProvider ? so if there is more than > 1 what would one do ?
##########
aws/src/main/java/org/apache/iceberg/aws/lakeformation/LakeFormationAwsClientFactory.java:
##########
@@ -144,26 +161,40 @@ private LakeFormationClient lakeFormation() {
static class LakeFormationCredentialsProvider implements
AwsCredentialsProvider {
private final LakeFormationClient client;
private final String tableArn;
+ private final long refreshLeadTimeMs;
+ private final CachedSupplier<AwsCredentials> cache;
- LakeFormationCredentialsProvider(LakeFormationClient lakeFormationClient,
String tableArn) {
+ LakeFormationCredentialsProvider(
Review Comment:
can we structure this more like VendedCredProvider in terms of cache
construction and modularization
https://github.com/apache/iceberg/blob/main/aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
